quarto publish action deletes pr previews #135
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
NBIS/Training-Tech-shorts#135
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Turns out that since quarto-cli v1.3
quarto publish(and, by extension, the corresponding GHA action) cleans the site directory before rendering (see for examplegithub.com/NBISweden/Training-Tech-shorts@b45bf0b4ad). This means that all PR previews are deleted when a PR is merged. The fix for this is to adapt the publish workflow to not use the quarto publish action, but instead resort to the quarto render action and push the rendered page to thegh-pagesbranch manually.I will fix this asap, but it might be a while. Happy if someone else (perhaps with copilot?) can take it before that :)
Just to keep the reference before closing my browser tab:
github.com/quarto-dev/quarto-cli@246f070259In practice this might not be a big issue. Normally there would likely be only one PR following a walkthrough. As long we're aware, schedule updates should only come when lessons have been merged too, so that should minimally affect previews too.
Yes, and the preview is probably recreated with the next commit to the affected PR, so the impact should be relatively small. Still good to leave this issue open until fixed, I guess.