The checksum files should include the decrypted filenames #122

New issue

Closed

opened 2026-06-09 07:17:33 +00:00 by aaperis · 0 comments

aaperis commented

2026-06-09 07:17:33 +00:00

(Migrated from github.com)

Describe the bug

The checksums correspond to the decrypted files so that the checksum text file should contain the decrypted filenames, i.e. same names but with .c4gh stripped.

cat EGAD00000000001-selected-files.sha256
87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb  generated-file-00000000002.c4gh
87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb  generated-file-00000000003.c4gh
...

Steps to reproduce

Download some files and its corresponding checksum file, decrypt the files:

sda-cli decrypt -key <path-to-private-c4gh-key> *.c4gh

then try to check the files:

cat EGAD00000000001-selected-files.sha256 | sha256sum --check
generated-file-00000000002.c4gh: FAILED
generated-file-00000000003.c4gh: FAILED
...

Expected behavior

cat EGAD00000000001-selected-files.sha256 
87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb  generated-file-00000000002
87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb  generated-file-00000000003
...

cat EGAD00000000001-selected-files.sha256 | sha256sum --check
generated-file-00000000002: OK
generated-file-00000000003: OK
...

## Describe the bug The checksums correspond to the decrypted files so that the checksum text file should contain the decrypted filenames, i.e. same names but with `.c4gh` stripped. ``` cat EGAD00000000001-selected-files.sha256 87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb generated-file-00000000002.c4gh 87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb generated-file-00000000003.c4gh ... ``` ## Steps to reproduce Download some files and its corresponding checksum file, decrypt the files: ``` sda-cli decrypt -key <path-to-private-c4gh-key> *.c4gh ``` then try to check the files: ``` cat EGAD00000000001-selected-files.sha256 | sha256sum --check generated-file-00000000002.c4gh: FAILED generated-file-00000000003.c4gh: FAILED ... ``` ## Expected behavior ``` cat EGAD00000000001-selected-files.sha256 87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb generated-file-00000000002 87102bbf342eb0038f60366fc44caf7711f42ae18d98cc022aed0292d451c4cb generated-file-00000000003 ... ``` ``` cat EGAD00000000001-selected-files.sha256 | sha256sum --check generated-file-00000000002: OK generated-file-00000000003: OK ... ```