258 configurable OIDC timeouts #259

Merged
aaperis merged 3 commits from 258-configurable-oidc-timeouts into develop 2026-11-06 09:14:45 +00:00
aaperis commented 2026-11-04 14:10:41 +00:00 (Migrated from github.com)

This PR closes #258. This is a config feature request by the GS.

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

New optional config variable oidcHttpTimeoutMs that defaults to 3500 ms (the openid-client library default). This will allow an admin to tweak the timeout so that oidc client requests can complete in slow systems.

Testing

  • unit tests added that cover the config functionality

Definition of Done checklist

  • I have made an effort making the commit history understandable
  • I have performed a self-review of my own code and commented any hard-to-understand areas
  • Existing tests are passing and I wrote unit tests for new functionality
  • My changes generate no new warnings
  • Make sure the layout and text follow design sketches, if there are any
  • All Acceptance Criteria (AC) Fulfilled and checked in the Related issue
## Related issue(s) and PR(s) This PR closes #258. This is a config feature request by the GS. ## Type of change - [x] New feature (non-breaking change which adds functionality) ## List of changes made New optional config variable `oidcHttpTimeoutMs` that defaults to `3500` ms (the `openid-client` library default). This will allow an admin to tweak the timeout so that oidc client requests can complete in slow systems. ## Testing - unit tests added that cover the config functionality ## Definition of Done checklist - [x] I have made an effort making the commit history understandable - [x] I have performed a self-review of my own code and commented any hard-to-understand areas - [x] Existing tests are passing and I wrote unit tests for new functionality - [x] My changes generate no new warnings - [x] Make sure the layout and text follow design sketches, if there are any - [x] All Acceptance Criteria (AC) Fulfilled and checked in the Related issue
KattisLej commented 2026-11-06 08:46:33 +00:00 (Migrated from github.com)

Starting review ...

Starting review ...
KattisLej (Migrated from github.com) approved these changes 2026-11-06 09:14:36 +00:00
KattisLej (Migrated from github.com) left a comment

This makes total sense and the tests are covering most of the cases. I am happy to see that the documentation and the json example file are updated.

This makes total sense and the tests are covering most of the cases. I am happy to see that the documentation and the json example file are updated.
Sign in to join this conversation.
No description provided.