NBIS/sda-download-ui
Watch
2
0
Fork
You've already forked sda-download-ui
 0
Code Issues 9 Pull requests 1 Projects Releases 1 Packages Wiki Activity Actions

feat: add sda dev stack config and compose files #24

Merged
aaperis merged 3 commits from 3-sda-download-dev-stack into develop 2026-04-15 07:39:24 +00:00
Conversation 11 Commits 3 Files changed 17 +1311
aaperis commented 2026-04-08 21:11:40 +00:00 (Migrated from github.com)

Related issue(s) and PR(s)

This PR closes #3 .

Type of change

  • New feature (non-breaking change which adds functionality)

List of changes made

Added:

  • docker compose file and necessary configuration files to run locally sda-download
  • the stack includes a script that populates the database and storage with one dataset, including one file. This script can be extended with more data in the future if needed.
  • detailed README file with description of the stack and instructions how to run and test

Updated:

  • Main README file

Testing

  • Instructions on how to test

Follow the instructions in the README.

  • Documentation Updated (if applicable):
    • Relevant documentation is current.

Follow-up issues

After I pushed the dev-tools folder I noticed that the linter action failed. I fixed this temporarily here in my last commit but this is not a good solution longterm. The bug and the fix are described in #25 .

  • EDIT: #25 was fixed so I removed the temporary commit fix from this PR.
## Related issue(s) and PR(s) This PR closes #3 . ## Type of change - [x] New feature (non-breaking change which adds functionality) ## List of changes made Added: - docker compose file and necessary configuration files to run locally `sda-download` - the stack includes a script that populates the database and storage with one dataset, including one file. This script can be extended with more data in the future if needed. - detailed README file with description of the stack and instructions how to run and test Updated: - Main README file ## Testing - Instructions on how to test Follow the instructions in the README. - [x] **Documentation Updated (if applicable):** - Relevant documentation is current. ## Follow-up issues After I pushed the dev-tools folder I noticed that the linter action failed. I fixed this temporarily here in my last commit but this is not a good solution longterm. The bug and the fix are described in #25 . - EDIT: #25 was fixed so I removed the temporary commit fix from this PR.
KattisLej (Migrated from github.com) reviewed 2026-04-09 08:36:03 +00:00
dev-tools/sda-dev-stack.yml
@ -0,0 +1,302 @@
# Lightweight dev stack for the sda-download v2 API.
KattisLej (Migrated from github.com) commented 2026-04-09 08:36:03 +00:00

It would be good to use a port we don't use in other projects, we have a document for this:
https://scilifelab.atlassian.net/wiki/spaces/NSDT/pages/3640885308/Ports+in+use+within+Meerkats+projects
I think it's not totally up to date but 8000 is used by the open pollen api
This concerns only development

It would be good to use a port we don't use in other projects, we have a document for this: https://scilifelab.atlassian.net/wiki/spaces/NSDT/pages/3640885308/Ports+in+use+within+Meerkats+projects I think it's not totally up to date but 8000 is used by the open pollen api This concerns only development
KattisLej (Migrated from github.com) reviewed 2026-04-09 08:37:59 +00:00
dev-tools/README.md
@ -0,0 +30,4 @@
TOKEN=$(curl -s http://localhost:8001/tokens | jq -r '.[0]')
# List datasets
curl -H "Authorization: Bearer $TOKEN" http://localhost:8085/datasets
KattisLej (Migrated from github.com) commented 2026-04-09 08:38:00 +00:00

When I did this I got:
{"detail":"Missing, invalid, or expired bearer token.","status":401,"title":"Unauthorized"}

When I did this I got: {"detail":"Missing, invalid, or expired bearer token.","status":401,"title":"Unauthorized"}
KattisLej commented 2026-04-09 12:22:57 +00:00 (Migrated from github.com)

I'm taking a look at this PR

I'm taking a look at this PR
aaperis (Migrated from github.com) reviewed 2026-04-13 15:27:58 +00:00
dev-tools/sda-dev-stack.yml
@ -0,0 +1,302 @@
# Lightweight dev stack for the sda-download v2 API.
aaperis (Migrated from github.com) commented 2026-04-13 15:27:58 +00:00

Changed the exposed port 8000 to 8001 and updated the confluence page with all the exported ports of this compose file.

Changed the exposed port `8000` to `8001` and updated the confluence page with all the exported ports of this compose file.
aaperis commented 2026-04-13 15:31:46 +00:00 (Migrated from github.com)

This should be now ready for review 😄

This should be now ready for review :smile:
🎉 1
KattisLej commented 2026-04-14 06:57:27 +00:00 (Migrated from github.com)

This should be now ready for review 😄

Great, I will continue with the review!

> This should be now ready for review 😄 Great, I will continue with the review!
KattisLej (Migrated from github.com) reviewed 2026-04-14 11:08:16 +00:00
dev-tools/README.md
@ -0,0 +1,167 @@
# Download API v2 - Local Development
KattisLej (Migrated from github.com) commented 2026-04-14 11:08:16 +00:00

Small typo at "which is will be deployed"

Small typo at "which is will be deployed"
KattisLej (Migrated from github.com) reviewed 2026-04-14 11:10:00 +00:00
frontend/package.json
KattisLej (Migrated from github.com) commented 2026-04-14 11:10:00 +00:00

This should be removed because frontend is now in its own folder

This should be removed because frontend is now in its own folder
KattisLej (Migrated from github.com) reviewed 2026-04-14 11:16:17 +00:00
KattisLej (Migrated from github.com) left a comment

I left some small comments that you can take a look at. One thought about the config.yaml file, since we have mock-auth and sda-auth:
Should this file be an example config file and then each one makes their own copy of it, so it is not tracked by Git? This can probably be done later on.

I left some small comments that you can take a look at. One thought about the config.yaml file, since we have mock-auth and sda-auth: Should this file be an example config file and then each one makes their own copy of it, so it is not tracked by Git? This can probably be done later on.
aaperis commented 2026-04-14 16:08:12 +00:00 (Migrated from github.com)

I left some small comments that you can take a look at. One thought about the config.yaml file, since we have mock-auth and sda-auth: Should this file be an example config file and then each one makes their own copy of it, so it is not tracked by Git? This can probably be done later on.

Good suggestions @KattisLej ! I moved the config.yaml into config.yaml.example and updated the README with info.

> I left some small comments that you can take a look at. One thought about the config.yaml file, since we have mock-auth and sda-auth: Should this file be an example config file and then each one makes their own copy of it, so it is not tracked by Git? This can probably be done later on. Good suggestions @KattisLej ! I moved the config.yaml into config.yaml.example and updated the README with info.
KattisLej (Migrated from github.com) approved these changes 2026-04-15 07:35:24 +00:00
KattisLej (Migrated from github.com) left a comment

I am very happy with this PR and you made a great job with the read me, because the instructions are very good. Easy to follow with the commands.

I have tested both the mock-auth and sda-auth and they both worked as expected. Great job!

I am very happy with this PR and you made a great job with the read me, because the instructions are very good. Easy to follow with the commands. I have tested both the mock-auth and sda-auth and they both worked as expected. Great job!
Sign in to join this conversation.
Reviewers
No reviewers
KattisLej
Labels
Clear labels   
backend

   
bug
Something isn't working

  
CI

   
dependencies
Pull requests that update a dependency file

  
design
Experience - ui design

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
frontend
UI

  
github_actions
Pull requests that update GitHub Actions code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
javascript
Pull requests that update javascript code

  
question
Further information is requested

  
refactoring

   
security

   
tooling
Development tools, linting, formatting, actions

  
UX

   
wontfix
This will not be worked on

No labels
backend
bug
CI
dependencies
design
documentation
duplicate
enhancement
frontend
github_actions
good first issue
help wanted
invalid
javascript
question
refactoring
security
tooling
UX
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
NBIS/sda-download-ui!24
No description provided.