Lint action should not run on the entire repository #25
Labels
No labels
backend
bug
CI
dependencies
design
documentation
duplicate
enhancement
frontend
github_actions
good first issue
help wanted
invalid
javascript
question
refactoring
security
tooling
UX
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
NBIS/sda-download-ui#25
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
From
package.json:means that the linter action will try to run the last three scripts on all files that are next to
package.json. Since the frontend files are at the root of the repo this triggers the scripts on other types of files e.g. docker compose files etc. thus raising errors and causing the action to fail.This problem has been fixed temporarily by replacing "." with "/src" in the above in #24 but this is not a good fix overall since we want the linters to check all the frontend files, including config files.
The fix would be to move all of the frontend files under a dedicated
/frontendfolder.Steps to reproduce
Add a non frontend compatible file in the repo.
Expected behavior
/srcfolder.