Fix release action #246

Merged

aaperis merged 5 commits from fix/release-action into develop

2026-10-13 11:54:57 +00:00

aaperis commented

2026-10-09 07:55:36 +00:00

(Migrated from github.com)

This PR fixes a bug related to the path of the Dockerfile in the release workflow and adds a couple of improvements.
Closes #240 .

Bug description

The previous value ../Dockerfile resolved outside the workspace and caused:

ERROR: failed to read dockerfile: open Dockerfile: no such file or directory

Fix implemented

changed to ./Dockerfile

Also added some workflow improvements:

Now the release action will build (and then exit) on PRs targeting main so that we are sure that the image builds successfully before merging.
Added needs: [lint, test] to the build-and-push job so it only runs if both the linting and testing workflows succeed. This means that test and lint actions will run twice if the release action is triggered but this is a small price to pay because the release action is triggered only on merge and on PRs to main.

Testing

I tested this by temporarily allowing the release workflow to run on develop PRs so it should be OK now.
The next step is to try it on a release PR targeting main after this is merged.

Definition of Done checklist

I have made an effort making the commit history understandable
I have performed a self-review of my own code and commented any hard-to-understand areas
My changes generate no new warnings
The fix has been verified manually, if applicable

## Related issue(s) and PR(s) This PR fixes a bug related to the path of the Dockerfile in the release workflow and adds a couple of improvements. Closes #240 . ## Bug description The previous value `../Dockerfile` resolved outside the workspace and caused: ``` ERROR: failed to read dockerfile: open Dockerfile: no such file or directory ``` ## Fix implemented - changed to `./Dockerfile` Also added some workflow improvements: - Now the release action will build (and then exit) on PRs targeting main so that we are sure that the image builds successfully before merging. - Added `needs: [lint, test]` to the `build-and-push` job so it only runs if both the linting and testing workflows succeed. This means that test and lint actions will run twice if the release action is triggered but this is a small price to pay because the release action is triggered only on `merge` and on `PRs to main`. ## Testing I tested this by temporarily allowing the release workflow to run on develop PRs so it should be OK now. The next step is to try it on a release PR targeting main after this is merged. ## Definition of Done checklist - [x] I have made an effort making the commit history understandable - [x] I have performed a self-review of my own code and commented any hard-to-understand areas - [x] My changes generate no new warnings - [x] The fix has been verified manually, if applicable

KattisLej (Migrated from github.com) reviewed

2026-10-09 07:55:36 +00:00

KattisLej commented

2026-10-13 07:37:23 +00:00

(Migrated from github.com)